From 769c213858a1f776704e7b00009482cbe746e248 Mon Sep 17 00:00:00 2001 From: Henry <617822642@qq.com> Date: Fri, 8 Feb 2019 10:50:33 +0800 Subject: [PATCH] switch shift to pop according to my test, pop is faster than shift, especially when the array is very long. --- src/algorithms/sorting/quick-sort/QuickSort.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/algorithms/sorting/quick-sort/QuickSort.js b/src/algorithms/sorting/quick-sort/QuickSort.js index 1c63c86e..0e8e44a0 100644 --- a/src/algorithms/sorting/quick-sort/QuickSort.js +++ b/src/algorithms/sorting/quick-sort/QuickSort.js @@ -19,12 +19,12 @@ export default class QuickSort extends Sort { const rightArray = []; // Take the first element of array as a pivot. - const pivotElement = array.shift(); + const pivotElement = array.pop(); const centerArray = [pivotElement]; // Split all array elements between left, center and right arrays. while (array.length) { - const currentElement = array.shift(); + const currentElement = array.pop(); // Call visiting callback. this.callbacks.visitingCallback(currentElement);